SFR-1969: Add "Read Online" functionality for UP items #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackiequach
requested review from
samanthaandrews,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
|
Nice work! Logic looks good. I'll wrap up my review tomorrow. |
| @@ -220,4 +221,39 @@ export default class EditionCardUtils { | |||
| : undefined; | |||
| return universityPress !== undefined; | |||
| } | |||
|
|
|||
| static createGetContent = (nyplIdentityCookie: any, router: NextRouter) => { | |||
| const fetchWithAuth = async (fulfillUrl: string, proxyUrl?: string) => { | |||
There was a problem hiding this comment.
Looks like this code could be reused to call other endpoints that need authentication besides the fulfill endpoint?
I think it's fine to keep it like this for now but we could consider abstracting this out to use with other endpoints later on.
kylevillegas93
approved these changes
Jul 12, 2024
…front-end into SFR-1969/web-reader-custom-fetcher
oliviawongnyc
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR does the following:
Testing requirements & instructions: